Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

[PIO-94] Fix to show stacktrace for errors thrown in queries.json REST API #393

Closed
wants to merge 1 commit into from
Closed

[PIO-94] Fix to show stacktrace for errors thrown in queries.json REST API #393

wants to merge 1 commit into from

Conversation

mars
Copy link
Member

@mars mars commented Jun 16, 2017 •
edited

We were getting intractable errors from queries.json requests, like this one without a stacktrace:

[ERROR] [ServerActor] Query '{
  "user": "000",
  "item": "000"
}' is invalid. Reason: Expected object but got JNothing

This pull request adds stacktraces to these errors using the pattern already present elsewhere in CreateServer.scala.

JIRA issue

@mars mars changed the title Fix to show stacktrace for errors thrown in queries.json REST API [PIO-94] Fix to show stacktrace for errors thrown in queries.json REST API Jun 16, 2017
@dszeto
Copy link
Contributor

dszeto commented Jun 20, 2017

LGTM. Thanks @mars !

@asfgit asfgit closed this in 914c743 Jun 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mars @dszeto