Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

[PIO-120] Process hangs if Elasticsearch is not available during train #432

Closed
wants to merge 1 commit into from
Closed

[PIO-120] Process hangs if Elasticsearch is not available during train #432

wants to merge 1 commit into from

Conversation

mars
Copy link
Member

@mars mars commented Sep 7, 2017 •
edited

Fixes PIO-120

This changeset ensures that the process exits gracefully after ES connection error.

Apologies for the indentation shift. This changeset simply wraps the body of the main function with:

try {
  // much existing code
} finally {
  CleanupFunctions.run()
}

@mars
Copy link
Member Author

mars commented Sep 7, 2017

Would be great to have this included in 0.12.0 release.

dszeto
dszeto approved these changes Sep 11, 2017
View reviewed changes
Copy link
Contributor

@dszeto dszeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @mars !

@asfgit asfgit closed this in 3451836 Sep 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dszeto dszeto dszeto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mars @dszeto