fix bug in seek if no messages in topic #1277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Feb 24, 2018
| @@ -1259,6 +1259,9 @@ public void seek(MessageId messageId) throws PulsarClientException { | |||
|
|
|||
| long requestId = client.newRequestId(); | |||
| MessageIdImpl msgId = (MessageIdImpl) messageId; | |||
| if (msgId.getEntryId() == -1) { | |||
There was a problem hiding this comment.
This might not be necessary correct. (ledgerId=5, entryId=-1) is a valid position to seek and it should not got to "earliest"
There was a problem hiding this comment.
Gotcha I will close this PR then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you call getLastMessageId and then use that messageId to seek, the seek will throw an exception since the ledgerId will exist but the entryId will be -1