Shade pulsar-functions-runtime instead of pulsar-functions-worker #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @srkukarni @jerrypeng |
merlimat
approved these changes
Mar 6, 2018
| <groupId>${project.groupId}</groupId> | ||
| <artifactId>pulsar-common</artifactId> | ||
| <version>${project.version}</version> | ||
| <exclusions> |
There was a problem hiding this comment.
Why do we need to exclude checksum here?
There was a problem hiding this comment.
because bookkeeper-server-shaded jar include the circe-checksum when shading guava. so circe-checksum is effectively available in pulsar-broker when including bookkeeper-server-shaded jar. so excluding pulsar-common to make the behavior more deterministic.
that said, we probably don't have to exclude it though. because in the classpath we have both shaded guava and non-shaded guava.
|
merged to latest master since the new |
lhotari
added a commit
to lhotari/pulsar
that referenced
this pull request
Feb 19, 2021
- pulsar-functions-worker-shaded was removed already by apache#1351
merlimat
pushed a commit
that referenced
this pull request
Feb 20, 2021
- pulsar-functions-worker-shaded was removed already by #1351
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
pulsar-functions-runtimeis required by worker/broker and also it would be packaged into a fat jar to used by process runtime to invoke function executions.so
pulsar-functions-runtimenotpulsar-functions-worker.Modifications
runtime-shade: package all the dependencies that use netty and protobuf and shade netty and protobuf, it also exclude the shaded client dependency. so that it can be integrated into worker and be used as part of worker.runtime-all: this is the module for packagingruntime-shadeand a non-shade pulsar-client to produce a fat jar for java process runtime.pulsar-client-toolsandpulsar-brokerto usepulsar-functions-workersince worker module now is using ashadedruntime jar, there will be no protobuf/netty conflicts.At the same time, changed using bookkeeper/test-jar to bookkeeper-server-tests-shaded, so it won't pollute the classpath.
Result