Converted to v2 topic names test related to ProducerConsumerBase #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
force-pushed
the
test-v2-topics
branch
from
3ca7308
to
085139d
Compare
merlimat
force-pushed
the
test-v2-topics
branch
from
085139d
to
2dfed20
Compare
sijie
reviewed
Apr 12, 2018
| @@ -128,7 +128,7 @@ public void deleteNamespace(@PathParam("property") String property, @PathParam(" | |||
| } | |||
|
|
|||
| @DELETE | |||
| @Path("/{property}/{namespace}/bundle/{bundle}") | |||
There was a problem hiding this comment.
hmm this sounds like a breaking change, no?
There was a problem hiding this comment.
This is only relative to v2 namespace. It was broken when v2 handler created.
| import org.apache.pulsar.broker.web.NoSwaggerDocumentation; | ||
| import org.apache.pulsar.common.naming.TopicName; | ||
|
|
||
| @Path("/v2/destination/") |
There was a problem hiding this comment.
It's probably worth a comment in the code, but it's correct.
The lookup API was already /v2/ in Pulsar 1.xxx. This was internally versioned at Yahoo to not clash from earlier API.
Since we're adding now the "Pulsar v2" we cannot rename this topic lookup into /v1. Rather the difference here would be : lookup/v2/destination/persistent/prop/cluster/ns/topic vs lookup/v2/topic/persistent/prop/ns/topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is the first set of changes to convert unit tests to use v2 topic names.
The PR contains also fixes, mainly to v2 lookup APIs to make sure all the functionalities were supported.
This first batch started the conversion from
ProducerConsumerBasetest class and all the tests that extends from that. AV1_ProducerConsumerTesttest has been retained with v1 name to ensure we don't break existing topics.