fix behavior of JSONSchema for derived classes #2577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srkukarni
approved these changes
Sep 13, 2018
sijie
approved these changes
Sep 13, 2018
|
run tests |
|
run cpp tests |
|
run integration tests |
1 similar comment
|
run integration tests |
|
rerun integration tests |
|
run java8 tests |
|
run integration tests |
|
@jerrypeng are some unittests failing because of this change? |
jerrypeng
force-pushed
the
json_polymorphism
branch
from
25934c8
to
d7e3b52
Compare
|
rerun java8 tests |
|
rerun integration tests |
|
run java8 tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently declaring a JSONSchema of a certain class and serializing a instance of a derived class does not produce the correct behavior