Add timeout on zkDataCache dependent task #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
approved these changes
Apr 18, 2017
| @@ -74,6 +74,7 @@ | |||
| protected final Cache<String, Set<String>> childrenCache; | |||
| protected final Cache<String, Boolean> existsCache; | |||
| protected final OrderedSafeExecutor executor; | |||
| public static final int cacheTimeOutInSec = 120; | |||
There was a problem hiding this comment.
We could keep it a bit lower than that. What about 30sec?
There was a problem hiding this comment.
ZK read operation should complete fairly quickly. If anyway we timeout early, it would just mean permission denied for one particular request but it will be able to catch up later.
saandrews
approved these changes
Apr 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add timeout on blocking call which waits on future returned by ZkCache. Due to unknown reason if ZkCache couldn't complete the returned future then it blocks threads forever. So, timeout will interrupt blocked threads and logs the warning of this behavior.
Modifications
Add timeout on blocking call which waits on future returned by ZkCache.
Result
Timeout will interrupt blocked threads and logs the warning of this behavior.