Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATIS-1264. Move routingTable to RaftRpcRequestProto #375

Merged
merged 2 commits into from
Dec 25, 2020
Merged

RATIS-1264. Move routingTable to RaftRpcRequestProto #375

merged 2 commits into from
Dec 25, 2020

Conversation

runzhiwang
Copy link
Contributor

What changes were proposed in this pull request?

Move routingTable to RaftRpcRequestProto

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/RATIS-1264

How was this patch tested?

no need new test

Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks. Just a minor comment on the proto field number.

ratis-proto/src/main/proto/Raft.proto Outdated Show resolved Hide resolved
@runzhiwang runzhiwang closed this Dec 25, 2020
@runzhiwang runzhiwang reopened this Dec 25, 2020
@runzhiwang
Copy link
Contributor Author

@szetszwo Thanks for review. Because ci passed, so I merge it.

@runzhiwang runzhiwang merged commit 5cb7e31 into apache:master Dec 25, 2020
symious pushed a commit to symious/ratis that referenced this pull request Feb 19, 2024
* RATIS-1264. Move routingTable to RaftRpcRequestProto

* fix code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants