RATIS-1318. Remove incubating #426

runzhiwang · 2021-02-20T05:39:31Z

What changes were proposed in this pull request?

Remove incubating

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/RATIS-1318

How was this patch tested?

no need new ut.

szetszwo · 2021-02-20T06:46:01Z

@runzhiwang , thanks a lot for working on this. There are a few other "incubator" or "incubating" found in make_rc.sh.

-- ./dev-support/make_rc.sh ---------------------------------------------------
 82:   svn co https://dist.apache.org/repos/dist/dev/incubator/ratis "$SVNDISTDIR"
119:   tar zvxf "$projectdir/ratis-assembly/target/apache-ratis-incubating-${RATISVERSION}-src.tar.gz"
120:   cd "apache-ratis-incubating-${RATISVERSION}"
130:   cp "$WORKINGDIR/apache-ratis-incubating-${RATISVERSION}/ratis-assembly/target/apache-ratis-incubating-${RATISVERSION}-bin.tar.gz" "apache-ratis-incubating-${RATISVERSION}-bin.tar.gz"
131:   cp "$projectdir/ratis-assembly/target/apache-ratis-incubating-${RATISVERSION}-src.tar.gz" "apache-ratis-incubating-${RATISVERSION}-src.tar.gz"
182:    10. (If the vote passed): Send out the next voting mail to the incubator mailing list.

szetszwo · 2021-02-20T06:48:13Z

dev-support/vagrant/README.md

@@ -13,7 +13,7 @@
 -->
 # What is this?

-This is a series of scripts for [Vagrant](https://vagrantup.com) to stand-up and test [Apache (Incubating) Ratis](https://ratis.incubator.apache.org/) servers and clients. One needs to have Vagrant and [VirtualBox](https://virtualbox.org) installed to stand-up these tests environments.
+This is a series of scripts for [Vagrant](https://vagrantup.com) to stand-up and test [Apache Ratis](https://ratis.incubator.apache.org/) servers and clients. One needs to have Vagrant and [VirtualBox](https://virtualbox.org) installed to stand-up these tests environments.


There are quite many other changes required in vagrant. Let's change them all together in a separated JIRA?

-- ./dev-support/vagrant/README.md -------------------------------------------- 16: This is a series of scripts for [Vagrant](https://vagrantup.com) to stand-up and test [Apache (Incubating) Ratis](https://ratis.incubator.apache.org/) servers and clients. One needs to have Vagrant and [VirtualBox](https://virtualbox.org) installed to stand-up these tests environments. 1 occurrence(s) -- ./dev-support/vagrant/Vagrantfile ------------------------------------------ 24: RATIS_PATH = ::File.join(VAGRANT_HOME, 'incubator-ratis') 1 occurrence(s) -- ./dev-support/vagrant/bin/start_ratis_load_gen.sh -------------------------- 22: cd ${HOME}/incubator-ratis 1 occurrence(s) -- ./dev-support/vagrant/bin/start_ratis_server.sh ---------------------------- 25: cd ${HOME}/incubator-ratis/ 1 occurrence(s) -- ./dev-support/vagrant/screenrcs/namazu_hdd_screenrc ------------------------ 23: screen -t Disk0 0 /home/vagrant/namazu/bin/nmz inspectors fs -original-dir /home/vagrant/test_data/data0 -mount-point /home/vagrant/test_data/data0_slowed/ -autopilot /home/vagrant/incubator-ratis/dev-support/vagrant/namazu_configs/hdd_config.toml 24: screen -t Disk1 0 /home/vagrant/namazu/bin/nmz inspectors fs -original-dir /home/vagrant/test_data/data1 -mount-point /home/vagrant/test_data/data1_slowed/ -autopilot /home/vagrant/incubator-ratis/dev-support/vagrant/namazu_configs/hdd_config.toml 25: screen -t Disk2 0 /home/vagrant/namazu/bin/nmz inspectors fs -original-dir /home/vagrant/test_data/data2 -mount-point /home/vagrant/test_data/data2_slowed/ -autopilot /home/vagrant/incubator-ratis/dev-support/vagrant/namazu_configs/hdd_config.toml 3 occurrence(s) -- ./dev-support/vagrant/screenrcs/ratis_ratis-hdd-slowdown_screenrc ---------- 23: screen -t Server0 0 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_server.sh /home/vagrant/test_data/data0_slowed n0 n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002 24: screen -t Server1 1 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_server.sh /home/vagrant/test_data/data1_slowed n1 n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002 25: screen -t Server2 2 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_server.sh /home/vagrant/test_data/data2_slowed n2 n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002 26: screen -t LoadGen 3 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_load_gen.sh n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002 4 occurrence(s) -- ./dev-support/vagrant/screenrcs/ratis_ratis-server_screenrc ---------------- 23: screen -t Server0 0 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_server.sh /home/vagrant/test_data/data0 n0 n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002 24: screen -t Server1 1 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_server.sh /home/vagrant/test_data/data1 n1 n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002 25: screen -t Server2 2 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_server.sh /home/vagrant/test_data/data2 n2 n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002 26: screen -t LoadGen 3 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_load_gen.sh n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002 4 occurrence(s)

runzhiwang · 2021-02-20T06:58:56Z

-- ./dev-support/make_rc.sh ---------------------------------------------------
 82:   svn co https://dist.apache.org/repos/dist/dev/incubator/ratis "$SVNDISTDIR"
119:   tar zvxf "$projectdir/ratis-assembly/target/apache-ratis-incubating-${RATISVERSION}-src.tar.gz"
120:   cd "apache-ratis-incubating-${RATISVERSION}"
130:   cp "$WORKINGDIR/apache-ratis-incubating-${RATISVERSION}/ratis-assembly/target/apache-ratis-incubating-${RATISVERSION}-bin.tar.gz" "apache-ratis-incubating-${RATISVERSION}-bin.tar.gz"
131:   cp "$projectdir/ratis-assembly/target/apache-ratis-incubating-${RATISVERSION}-src.tar.gz" "apache-ratis-incubating-${RATISVERSION}-src.tar.gz"
182:    10. (If the vote passed): Send out the next voting mail to the incubator mailing list.

@szetszwo Hi, line 119, 120, 130, 131 already changed in this PR. line 82 need to change dir, if we remove incubator, the dir will be https://dist.apache.org/repos/dist/dev/ratis, which does not exist.

szetszwo · 2021-02-20T07:14:08Z

@runzhiwang , I just have created https://dist.apache.org/repos/dist/dev/ratis/ and copied KEYS to there.

runzhiwang · 2021-02-20T07:17:02Z

I just have created https://dist.apache.org/repos/dist/dev/ratis/ and copied KEYS to there.

@szetszwo Thanks, do we put release 2.0.0 to https://dist.apache.org/repos/dist/dev/ratis/? and do we need to copy the previous release such as 1.0.0 to https://dist.apache.org/repos/dist/dev/ratis/?

szetszwo · 2021-02-20T07:23:19Z

Yes, we should put the 2.0.0 release to the new dir. For the old releases, we will move them once we have fixed the links in the web pages.

runzhiwang · 2021-02-20T08:36:32Z

@szetszwo Hi, I have updated the patch, there are other "incubator" and "incubating" related to repository name and email, so I did not change them.

szetszwo

+1 the change looks good.

…ache#426)

RATIS-1318. Remove incubating

78613a4

runzhiwang requested a review from szetszwo February 20, 2021 05:40

szetszwo reviewed Feb 20, 2021

View reviewed changes

fix code review

b540471

szetszwo approved these changes Feb 20, 2021

View reviewed changes

szetszwo merged commit 50bbd63 into apache:master Feb 20, 2021

symious pushed a commit to symious/ratis that referenced this pull request Feb 20, 2024

RATIS-1318. Remove incubating from make_rc.sh and ratis-assembly. (ap…

25269bd

…ache#426)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RATIS-1318. Remove incubating #426

RATIS-1318. Remove incubating #426

runzhiwang commented Feb 20, 2021

szetszwo commented Feb 20, 2021 •

edited

szetszwo Feb 20, 2021

runzhiwang Feb 20, 2021

runzhiwang commented Feb 20, 2021

szetszwo commented Feb 20, 2021

runzhiwang commented Feb 20, 2021

szetszwo commented Feb 20, 2021

runzhiwang commented Feb 20, 2021

szetszwo left a comment

RATIS-1318. Remove incubating #426

RATIS-1318. Remove incubating #426

Conversation

runzhiwang commented Feb 20, 2021

What changes were proposed in this pull request?

What is the link to the Apache JIRA

How was this patch tested?

szetszwo commented Feb 20, 2021 • edited

szetszwo Feb 20, 2021

Choose a reason for hiding this comment

runzhiwang Feb 20, 2021

Choose a reason for hiding this comment

runzhiwang commented Feb 20, 2021

szetszwo commented Feb 20, 2021

runzhiwang commented Feb 20, 2021

szetszwo commented Feb 20, 2021

runzhiwang commented Feb 20, 2021

szetszwo left a comment

Choose a reason for hiding this comment

szetszwo commented Feb 20, 2021 •

edited