RATIS-1318. Remove incubating#426
Merged
szetszwo merged 2 commits intoapache:masterfrom Feb 20, 2021
runzhiwang:remove-incubating
Merged
RATIS-1318. Remove incubating#426szetszwo merged 2 commits intoapache:masterfrom runzhiwang:remove-incubating
szetszwo merged 2 commits intoapache:masterfrom
runzhiwang:remove-incubating
Conversation
Contributor
|
@runzhiwang , thanks a lot for working on this. There are a few other "incubator" or "incubating" found in make_rc.sh. |
szetszwo
reviewed
Feb 20, 2021
| # What is this? | ||
|
|
||
| This is a series of scripts for [Vagrant](https://vagrantup.com) to stand-up and test [Apache (Incubating) Ratis](https://ratis.incubator.apache.org/) servers and clients. One needs to have Vagrant and [VirtualBox](https://virtualbox.org) installed to stand-up these tests environments. | ||
| This is a series of scripts for [Vagrant](https://vagrantup.com) to stand-up and test [Apache Ratis](https://ratis.incubator.apache.org/) servers and clients. One needs to have Vagrant and [VirtualBox](https://virtualbox.org) installed to stand-up these tests environments. |
Contributor
There was a problem hiding this comment.
There are quite many other changes required in vagrant. Let's change them all together in a separated JIRA?
-- ./dev-support/vagrant/README.md --------------------------------------------
16: This is a series of scripts for [Vagrant](https://vagrantup.com) to stand-up and test [Apache (Incubating) Ratis](https://ratis.incubator.apache.org/) servers and clients. One needs to have Vagrant and [VirtualBox](https://virtualbox.org) installed to stand-up these tests environments.
1 occurrence(s)
-- ./dev-support/vagrant/Vagrantfile ------------------------------------------
24: RATIS_PATH = ::File.join(VAGRANT_HOME, 'incubator-ratis')
1 occurrence(s)
-- ./dev-support/vagrant/bin/start_ratis_load_gen.sh --------------------------
22: cd ${HOME}/incubator-ratis
1 occurrence(s)
-- ./dev-support/vagrant/bin/start_ratis_server.sh ----------------------------
25: cd ${HOME}/incubator-ratis/
1 occurrence(s)
-- ./dev-support/vagrant/screenrcs/namazu_hdd_screenrc ------------------------
23: screen -t Disk0 0 /home/vagrant/namazu/bin/nmz inspectors fs -original-dir /home/vagrant/test_data/data0 -mount-point /home/vagrant/test_data/data0_slowed/ -autopilot /home/vagrant/incubator-ratis/dev-support/vagrant/namazu_configs/hdd_config.toml
24: screen -t Disk1 0 /home/vagrant/namazu/bin/nmz inspectors fs -original-dir /home/vagrant/test_data/data1 -mount-point /home/vagrant/test_data/data1_slowed/ -autopilot /home/vagrant/incubator-ratis/dev-support/vagrant/namazu_configs/hdd_config.toml
25: screen -t Disk2 0 /home/vagrant/namazu/bin/nmz inspectors fs -original-dir /home/vagrant/test_data/data2 -mount-point /home/vagrant/test_data/data2_slowed/ -autopilot /home/vagrant/incubator-ratis/dev-support/vagrant/namazu_configs/hdd_config.toml
3 occurrence(s)
-- ./dev-support/vagrant/screenrcs/ratis_ratis-hdd-slowdown_screenrc ----------
23: screen -t Server0 0 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_server.sh /home/vagrant/test_data/data0_slowed n0 n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002
24: screen -t Server1 1 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_server.sh /home/vagrant/test_data/data1_slowed n1 n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002
25: screen -t Server2 2 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_server.sh /home/vagrant/test_data/data2_slowed n2 n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002
26: screen -t LoadGen 3 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_load_gen.sh n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002
4 occurrence(s)
-- ./dev-support/vagrant/screenrcs/ratis_ratis-server_screenrc ----------------
23: screen -t Server0 0 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_server.sh /home/vagrant/test_data/data0 n0 n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002
24: screen -t Server1 1 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_server.sh /home/vagrant/test_data/data1 n1 n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002
25: screen -t Server2 2 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_server.sh /home/vagrant/test_data/data2 n2 n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002
26: screen -t LoadGen 3 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_load_gen.sh n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002
4 occurrence(s)
Contributor
Author
@szetszwo Hi, line 119, 120, 130, 131 already changed in this PR. line 82 need to change dir, if we remove incubator, the dir will be https://dist.apache.org/repos/dist/dev/ratis, which does not exist. |
Contributor
|
@runzhiwang , I just have created https://dist.apache.org/repos/dist/dev/ratis/ and copied KEYS to there. |
Contributor
Author
@szetszwo Thanks, do we put release 2.0.0 to https://dist.apache.org/repos/dist/dev/ratis/? and do we need to copy the previous release such as 1.0.0 to https://dist.apache.org/repos/dist/dev/ratis/? |
Contributor
|
Yes, we should put the 2.0.0 release to the new dir. For the old releases, we will move them once we have fixed the links in the web pages. |
Contributor
Author
|
@szetszwo Hi, I have updated the patch, there are other "incubator" and "incubating" related to repository name and email, so I did not change them. |
szetszwo
approved these changes
Feb 20, 2021
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Feb 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove incubating
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1318
How was this patch tested?
no need new ut.