This repository has been archived by the owner on Aug 4, 2022. It is now read-only.
[REEF-205] Add Org.Apache.REEF.Bridge.JAR #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new project to the .NET solution: `Org.Apache.REEF.Bridge.JAR`. Upon build, it checks whether the shaded jar for `reef-bridge-java` exists. If not, it will be built. The build will fail if M2_HOME isn't set and. Also, this PR adds the shaded jar to `reef-bridge-java`. JIRA: [REEF-205](https://issues.apache.org/jira/browse/REEF-205) Pull Request: This closes
|
I am looking at this. |
| under the License. | ||
| --> | ||
| <Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="12.0"> | ||
| <Import Project="..\build.props" /> |
There was a problem hiding this comment.
use $(SolutionDir)\build.props
Removed the upgrade notices.
|
Reef-pull-request-ubuntu #326 SUCCESS |
| <!--The folder where the REEF sources have been checked out to.--> | ||
| <REEF_Source_Folder>$([System.IO.Path]::GetFullPath($(MSBuildProjectDirectory)\..\..\..))</REEF_Source_Folder> | ||
| <!--The shaded jar of the bridge --> | ||
| <Bridge_JAR>$(REEF_Source_Folder)\lang\java\reef-bridge-java\target\reef-bridge-java-$(REEF_Version)-shaded.jar</Bridge_JAR> |
There was a problem hiding this comment.
use
|
Reef-pull-request-ubuntu #327 SUCCESS |
|
Reef-pull-request-ubuntu #328 SUCCESS |
|
Reef-pull-request-windows #168 ABORTED |
|
Reef-pull-request-windows #169 SUCCESS |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new project to the .NET solution:
Org.Apache.REEF.Bridge.JAR. Upon build, it checks whether the shaded jar forreef-bridge-javaexists. If not, it will be built. The build will fail if M2_HOME isn't set and.Also, this PR adds the shaded jar to
reef-bridge-java.JIRA: REEF-205