This repository has been archived by the owner on Aug 4, 2022. It is now read-only.
[REEF-308]: Race condition and clock skew issues in Tasks reporting back to JobDriver #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ack to JobDriver This does not solve the issue, but will not fail the job driver if tasks have sent an out of order status message, given that the status reported is forward-progressing. JIRA: [REEF-308](https://issues.apache.org/jira/browse/REEF-308)
|
Reef-pull-request-ubuntu #513 SUCCESS |
| taskStatusProto.getRecovery() // for task from recovered evaluators | ||
| ) { | ||
|
|
||
| // REEF-308 exposes a bug where the .NET evaluator does not send its states in the right order |
There was a problem hiding this comment.
Nitpick: Use [REEF-308] such that we can find these lines later when we fix the root cause. Also, add a reference to [REEF-289] which is the likely root cause here.
|
I did a pass, just a minor nitpick. |
|
Reef-pull-request-ubuntu #516 SUCCESS |
|
Reef-pull-request-windows #343 ABORTED |
|
This looks good, I will merge it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not solve the issue, but will not fail the job driver if tasks have sent an out of order status message, given that the status reported is forward-progressing.
JIRA: REEF-308