[REEF-460]: Remove all generated files on mvn clean #293
Conversation
|
Reef-pull-request-windows2 #66 SUCCESS |
|
Reef-pull-request-ubuntu #72 FAILURE |
| @@ -40,7 +40,7 @@ | |||
|
|
|||
| @Inject | |||
| WorkingDirectoryTempFileCreator() throws IOException { | |||
| this.tempFolderAsFile = new File("./reef/temp"); | |||
| this.tempFolderAsFile = new File("./target/reef/temp"); | |||
There was a problem hiding this comment.
@markusweimer This change will affect temporary directories created in YARN, Mesos, and HDInsight as well as local test runs. Is this the behavior we want?
There was a problem hiding this comment.
No, I don't think so. This is for temporary files created by the driver or evaluator. Those file should reside withing in ./reef/ hierarchy.
There was a problem hiding this comment.
I see. I will keep ./reef/temp.
This pull request addressed the issue by * Change test root folder to `target/REEF_LOCAL_RUNTIME` JIRA: [REEF-460](https://issues.apache.org/jira/browse/REEF-460)
|
@markusweimer Could you please take a look? I've addressed your comments. |
|
Reef-pull-request-ubuntu #74 SUCCESS |
|
Reef-pull-request-windows2 #68 SUCCESS |
|
I'll test and merge. This looks good. |
This pull request addressed the issue by
target/REEF_LOCAL_RUNTIMEJIRA: REEF-460