[REEF-940] Create .NET job resource uploader using IFileSystem #637
Conversation
|
|
||
| private long DateTimeToUnixTimestamp(DateTime dateTime) | ||
| { | ||
| return (long) (dateTime - Epoch).TotalSeconds; |
There was a problem hiding this comment.
I dont know yet. Will fix when I figure out.
|
@anupam128 This looks good in general, just a few minor comments. Thanks! |
| @@ -59,6 +60,10 @@ under the License. | |||
| <Project>{5094c35b-4fdb-4322-ac05-45d684501cbf}</Project> | |||
| <Name>Org.Apache.REEF.Client</Name> | |||
| </ProjectReference> | |||
| <ProjectReference Include="..\Org.Apache.REEF.IO\Org.Apache.REEF.IO.csproj"> | |||
There was a problem hiding this comment.
We usually replace the .. with a variable.
|
@anupam128 I've done a pass. |
|
@afchung @markusweimer I have made the changes. |
|
Looks good. Have you done any E2E tests? |
|
@afchung I don't have a way to do E2E test yet (HadoopFileSystem does not have GetFileStatus API) REEF-922 with include this E2E testing. |
|
@anupam128 OK, I'll test and merge after @markusweimer signs off. |
| /// </summary> | ||
| internal sealed class FileSystemJobResourceUploader : IJobResourceUploader | ||
| { | ||
| private static readonly Logger Log = Logger.GetLogger(typeof(LegacyJobResourceUploader)); |
There was a problem hiding this comment.
This uses the wrong logger name, I believe?
|
I did another pass, left a comment. Other than that: +1 on merging. |
|
@afchung @markusweimer thanks for reviewing. I have made the change. |
|
I'll test and merge. |
JIRA: [REEF-940](https://issues.apache.org/jira/browse/REEF-940) Pull Request: Closes apache#637
JIRA:
REEF-940