[REEF-1007] Remove invalid notification email from Travis CI build script #672
Conversation
…ript JIRA: [REEF-1007](https://issues.apache.org/jira/browse/REEF-1007) Pull Request: This closes apache#672
dongjoon-hyun
force-pushed
the
REEF-1007
branch
from
81b9680
to
d9a53f8
Compare
| @@ -33,7 +33,7 @@ cache: | |||
|
|
|||
| notifications: | |||
There was a problem hiding this comment.
Is notifications section mandatory if we don't want any notifications? Maybe we could remove it at all?
There was a problem hiding this comment.
Good point. I think you're right, but let me check for a while.
There was a problem hiding this comment.
Oh, according to the documentation (https://docs.travis-ci.com/user/notifications/), the default is sending notifications to committers. To disable notification, we should use false explicitly.
By default, email notifications are sent to the committer and the commit author, if they are members of the repository (that is, they have push or admin permissions for public repositories, or if they have pull, push or admin permissions for private repositories).
There was a problem hiding this comment.
Thank you for checking. I'll merge
|
Thank you for merging and amending commit log, @tcNickolas . |
|
Oh, @tcNickolas . Did you get the notification message? I suddenly got one. It should be like the following. |
|
No, I didn't. |
|
Sure! I reopen the issue and made a quick fix PR, #680 . |
Before this change Travis used invalid email, so there is no behavior change. JIRA: [REEF-1007](https://issues.apache.org/jira/browse/REEF-1007) Pull Request: This closes apache#672
JIRA:
REEF-1007
Pull Request:
This closes #