This repository has been archived by the owner on Feb 8, 2019. It is now read-only.
fix GEARPUMP-110, try streaming kmeans on Gearpump #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1, Thanks. |
| previousNumber += currentNumber | ||
| currentNumber = 0 | ||
| } | ||
| val newPoint = dataQueue.take() |
There was a problem hiding this comment.
this is a blocking call. We suggest against block in Task. You may use "poll" instead.
|
sorry, I was too optimistic previously. This example contains a cycle which cause the generation of process levels into dead loop. Please check https://github.com/apache/incubator-gearpump/blob/master/core/src/main/scala/io/gearpump/util/Graph.scala#L380 |
|
@manuzhang Yes, I find that |
|
Yes, please create a jira issue and open an PR if you've got a solution. |
manuzhang
added a commit
to manuzhang/incubator-gearpump
that referenced
this pull request
Jan 24, 2017
Author: manuzhang <owenzhang1990@gmail.com> Closes apache#5 from manuzhang/upgrade.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.