This repository has been archived by the owner on Feb 8, 2019. It is now read-only.
Refactor into a multi-module project #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdusbabek
force-pushed
the
grd_multi_module
branch
from
b8adeb5
to
b6be526
Compare
edwardcapriolo
suggested changes
Apr 13, 2017
pom.xml
Outdated
|
|
||
| <name>Gossip Parent</name> | ||
| <groupId>org.apache.gossip</groupId> | ||
| <artifactId>gossip</artifactId> |
There was a problem hiding this comment.
lets call the artifact gossip-parent
pom.xml
Outdated
| @@ -77,9 +83,9 @@ | |||
|
|
|||
| <dependencies> | |||
There was a problem hiding this comment.
Should we move the dependencies into the module?
There was a problem hiding this comment.
I'm on the fence. In other projects that have had global dependencies, I've left them in the parent. Most of these seem to fall into that category.
There was a problem hiding this comment.
In the end run there probably will be a few that are global and some that are specific. I do believe that the process should start with nothing in the global and then as things are shared by more than two modules they are pulled into the global
There was a problem hiding this comment.
No problem. Done.
gdusbabek
force-pushed
the
grd_multi_module
branch
from
ebd8ddd
to
a4b96b8
Compare
* add *.ipr to .gitignore * modify existing pom to be a parent. create new pom for gossip-core. * I left all properties and dependencies in the parent, as they seemed to be a fairly general set of dependencies. move all the code. * rename parent module: gossip -> gossip-parent * move dependencies into child module
gdusbabek
force-pushed
the
grd_multi_module
branch
from
a4b96b8
to
298b1ae
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No code was harmed while making this PR
Create a parent pom and move all code into a submodule (gossip-base). Subsequent PRs can create new summodules, move more code, etc.
This is for GOSSIP-78.