RIPPLE-74 Ripple does not pass geolocation info to app.

The underlying problem here was that Ripple was failing to patch window.navigator.
apache · May 6, 2015 · fb3127b · fb3127b
1 parent ded244a
commit fb3127b
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/lib/client/emulatorBridge.js b/lib/client/emulatorBridge.js
@@ -76,11 +76,18 @@ module.exports = {
         _doc = doc;
         _xhr = win.XMLHttpRequest;
 
-        var marshal = function (obj, key) {
-                window[key] = win[key] = obj;
-            },
-            currentPlatform = platform.current(),
-            sandbox = {};
+        function marshal(obj, key) {
+            // Use defineProperty, otherwise we won't be able to override built-in read-only properties.
+            Object.defineProperty(window, key, {
+                value: obj
+            });
+            Object.defineProperty(win, key, {
+                value: obj
+            });
+        }
+
+        var currentPlatform = platform.current(),
+            sandbox         = {};
 
         marshal(window.tinyHippos, "tinyHippos");
         marshal(window.XMLHttpRequest, "XMLHttpRequest");