Skip to content
This repository has been archived by the owner on Feb 8, 2019. It is now read-only.

Commit

Permalink
Fixed a couple of test problems
Browse files Browse the repository at this point in the history
Updated version of jsdom from 0.6.x to 3.1.0.
The older jsdom fails with a RangeError, saying
"The normalization form should be one of NFC, NFD, NFKC, NFKD."
I tested the newer jsdom with node 0.11.15 and 0.12.0.
I can't get Ripple to install with node 0.10.5, because some modules
require version specifications containing "^", and that form isn't
understood by the version of npm that comes with node 0.10.5.

Also had to update bower to version 1.3.12 for similar reasons.
It wasn't successfully installing jasmine into thirdparty folder.
Finally, fixed a unit test that only passed if two calls to Date retrned
the same value.  The calls are close together so this usually works,
but it does cause intermittant failures.
  • Loading branch information
jchorn authored and Tim Barham committed May 12, 2015
1 parent fb3127b commit 1bb7012
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions package.json
Expand Up @@ -36,12 +36,12 @@
"request": "2.12.0"
},
"devDependencies": {
"bower": "0.9.x",
"bower": "1.3.12",
"connect": "2.3.6",
"coverjs": "0.0.14",
"cssmin": "0.3.1",
"html-minifier": "0.4.5",
"jsdom": "0.6.x",
"jsdom": "3.1.0",
"jWorkflow": "0.x.x",
"semver": "^4.3.1",
"xmlhttprequest": "1.4.2"
Expand Down
2 changes: 1 addition & 1 deletion test/unit/client/cordova/globalization.js
Expand Up @@ -92,7 +92,7 @@ describe("cordova globalization bridge", function () {
});

it("calls moment with the provided date", function () {
var date = new Date();
var date = args[0].date;
glob.dateToString(success, fail, args);
expect(moment).toHaveBeenCalledWith(date);
});
Expand Down

0 comments on commit 1bb7012

Please sign in to comment.