[ROCKETMQ-268]add rocketmq-cpp code #27
Conversation
|
Trying to create a CMakeLists.txt on top of this PR, but it looks there is something missing: MetaqJson::Value jsonI grepped MetaqJson in the code, but no definition of this struct if found. Please double check the code is compilable. |
|
A second issue about alog, there are only header files and binary static lib file, where is source code for the static lib files? |
|
About the disruptor module in src/thread, copyright declarations of this module files are different. Is the source code copied from somewhere? If so, is its license compatible with Apache Software Foundation? |
|
Many useless files are included, for example in project folder. Can we remove them? |
|
As it's now part of the Apache RocketMQ project, IMO, rocketmq namespace should be used instead of metaq. |
|
For build and install, cmake and Makefile are all supported on linux platform now. Thanks |
vincentWangKB
changed the title
|
@lizhanhui all build issue had been fixed, please pull latest code, thanks |
|
Yes, I see your update...Thanks for you contribution. CMake, IMO, is very good to have! One more thing, I think we can assume dependent libraries are all installed in the standard default way, thus, we can use find_package features and developers do not have to modify CMake build file. If required libraries are missing, we just abort in the cmake phase. |
|
@lizhanhui alog lib had been instead by boost::log, thanks your advisement |
|
I suggest that we'd better squash the commits before merging a PR. |
|
@vesense Yes, we will do this before actually merging |
|
@vincentWangKB Another issue with the code, currently all classes sit in the namespace of metaq, we should rename it to rocketmq. |
|
@vincentWangKB Any progress? It's been a while since last update to this PR. |
|
Maybe, we can merge it and create JIRA tickets to polish the code. Any idea? |
|
@lizhanhui namespace had been changed to rocketmq, thanks |
|
Though there are still quite a few unused files, I am fine to merge this PR first and fix issues later on. |
|
This patch looks good enough to be merged. Thanks @vincentWangKB |
remove unused boost file update README.md update readme.md update readme.md update readme add gitkeep to bin update readme.md update apache license info remove static dependency update readme.md add jsoncpp and libevent install discription udpate makefile update jsoncpp version unify dependency update readme support cmake instead alog by boost::log For cmake, remove alog remove alog comment [add rocketmq-cpp code #27] add cmake to readme use rocketmq namespace, update json version to 0.10.6 update cmakelist update json version to 0.10.6 remove makefile add default search path for jsoncpp and libevent Update README.md fix could not find jsoncpp issue support build on new g++ version Remove built .o files
|
This Pull Request has been merged and it's safe to close this PR. @vincentWangKB |
|
It is a good practice for apache way :-) |
|
Consider removing boost? This dependency is too large for a SDK not a complete project. |
|
close pull request, as rocketmq cpp code had been merged |
add rocketmq-cpp code