optimize: skip check lock #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bohehe
suggested changes
Jan 21, 2022
dk-lockdown
reviewed
Jan 21, 2022
| @@ -1,6 +1,7 @@ | |||
| package lock | |||
|
|
|||
| import ( | |||
| "encoding/json" | |||
There was a problem hiding this comment.
pls add a blank line after this lib
wybrobin
reviewed
Jan 25, 2022
| if err != nil { | ||
| return locker.manager.AcquireLock(locks, false) | ||
| } | ||
| skipCheckLock := applicationDataMap["skipCheckLock"] |
There was a problem hiding this comment.
参考mysql那边的代码，这里好像只有skipCheckLock==false
There was a problem hiding this comment.
已经更改了，这里目前只会有skipCheckLock==true
wybrobin
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://github.com/seata-golang/seata-golang/issues/
Ⅰ. Describe what this PR did
参考此issue提交
mysql那边的pr已经提交
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews