Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix xa driver failure #556

Merged
merged 6 commits into from May 14, 2023
Merged

Conversation

georgehao
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented May 13, 2023

Codecov Report

Merging #556 (fcf12e1) into master (2c522ad) will increase coverage by 0.22%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
+ Coverage   36.62%   36.84%   +0.22%     
==========================================
  Files         160      160              
  Lines       11136    11140       +4     
==========================================
+ Hits         4079     4105      +26     
+ Misses       6710     6686      -24     
- Partials      347      349       +2     
Impacted Files Coverage Δ
pkg/datasource/sql/driver.go 73.52% <100.00%> (+7.19%) ⬆️
pkg/datasource/sql/tx.go 53.33% <100.00%> (+9.63%) ⬆️
pkg/datasource/sql/xa/mysql_xa_connection.go 58.87% <100.00%> (+0.78%) ⬆️

... and 1 file with indirect coverage changes

@georgehao georgehao merged commit c5cb0c1 into apache:master May 14, 2023
5 checks passed
@georgehao georgehao changed the title Fix/fix xa bug1 feat: fix xa driver failure May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants