Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix xa local bug #566

Merged
merged 3 commits into from May 28, 2023
Merged

feat: fix xa local bug #566

merged 3 commits into from May 28, 2023

Conversation

georgehao
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

Codecov Report

Merging #566 (2e5df7b) into master (8e89c54) will increase coverage by 0.32%.
The diff coverage is 52.50%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
+ Coverage   36.99%   37.31%   +0.32%     
==========================================
  Files         160      160              
  Lines       11154    11206      +52     
==========================================
+ Hits         4126     4182      +56     
+ Misses       6681     6667      -14     
- Partials      347      357      +10     
Impacted Files Coverage Δ
pkg/client/client.go 0.00% <ø> (ø)
pkg/datasource/sql/db.go 49.24% <0.00%> (-2.80%) ⬇️
pkg/datasource/sql/driver.go 69.71% <ø> (ø)
...kg/datasource/sql/exec/at/multi_delete_executor.go 29.68% <ø> (ø)
pkg/datasource/sql/xa_resource_manager.go 4.80% <0.00%> (+0.07%) ⬆️
pkg/datasource/sql/xa/mysql_xa_connection.go 57.14% <51.51%> (-1.74%) ⬇️
pkg/datasource/sql/conn_xa.go 45.55% <72.41%> (+11.42%) ⬆️
pkg/datasource/sql/conn.go 19.73% <100.00%> (+0.53%) ⬆️
...ing/processor/client/rm_branch_commit_processor.go 36.36% <100.00%> (ø)
pkg/tm/transaction_executor.go 97.50% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

@georgehao georgehao merged commit 7c3867f into apache:master May 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants