support protobuf feature #1007

leizhiyuan · 2019-05-09T14:15:52Z

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov-io · 2019-05-09T14:19:49Z

Codecov Report

Merging #1007 into develop will decrease coverage by 9.69%.
The diff coverage is 28.91%.

@@              Coverage Diff              @@
##             develop    #1007      +/-   ##
=============================================
- Coverage      45.36%   35.66%    -9.7%     
- Complexity      1511     2156     +645     
=============================================
  Files            256      408     +152     
  Lines          10354    21931   +11577     
  Branches        1339     3056    +1717     
=============================================
+ Hits            4697     7822    +3125     
- Misses          5073    13041    +7968     
- Partials         584     1068     +484

Impacted Files	Coverage Δ	Complexity Δ
.../protobuf/generated/GlobalStatusResponseProto.java	`12.32% <ø> (ø)`	`8 <0> (?)`
...dec/seata/protocol/AbstractResultMessageCodec.java	`67.74% <ø> (ø)`	`5 <0> (?)`
...ansaction/AbstractTransactionRequestToRMCodec.java	`50% <ø> (ø)`	`1 <0> (?)`
...a/codec/protobuf/generated/RegisterTMResponse.java	`81.25% <ø> (ø)`	`2 <0> (?)`
...dec/protobuf/generated/MergedWarpMessageProto.java	`12.95% <ø> (ø)`	`9 <0> (?)`
.../codec/protobuf/generated/GlobalCommitRequest.java	`81.25% <ø> (ø)`	`2 <0> (?)`
...ansaction/AbstractTransactionRequestToTCCodec.java	`50% <ø> (ø)`	`1 <0> (?)`
...src/main/java/io/seata/codec/seata/SeataCodec.java	`80.64% <ø> (ø)`	`3 <0> (?)`
...codec/protobuf/manager/ProtobufConvertManager.java	`100% <ø> (ø)`	`5 <0> (?)`
...ata/codec/protobuf/generated/MessageTypeProto.java	`78.37% <ø> (ø)`	`27 <0> (?)`
... and 336 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bc2187...9b7a715. Read the comment docs.

* reform code * reform protobuf to same module * add new data * use upper case * fix bug,write new pb objetc type * write fullname to data * fix bug add test case

# Conflicts: # pom.xml

# Conflicts: # all/pom.xml # bom/pom.xml # core/pom.xml # core/src/main/java/io/seata/core/constants/ConfigurationKeys.java # core/src/main/java/io/seata/core/protocol/AbstractIdentifyResponse.java # core/src/main/java/io/seata/core/protocol/AbstractMessage.java # core/src/main/java/io/seata/core/protocol/MergedWarpMessage.java # core/src/main/java/io/seata/core/protocol/transaction/AbstractBranchEndRequest.java # core/src/main/java/io/seata/core/rpc/netty/MessageCodecHandler.java

slievrly · 2019-06-17T02:25:29Z

I will verify the function.

zhangthen

I run the branch in local machine , the result is normal.

slievrly · 2019-06-25T09:17:20Z

core/src/main/java/io/seata/core/rpc/netty/MessageCodecHandler.java

    private static final int MAGIC_HALF = -38;
    private static final int NOT_FOUND_INDEX = -1;

+    private static Configuration configuration = ConfigurationFactory.getInstance();
+
+    private static String serialize = configuration.getConfig(ConfigurationKeys.SERIALIZE_FOR_RPC);


should there be a default value that is compatible with the previous configuration file?

slievrly · 2019-06-25T09:36:42Z

core/src/main/java/io/seata/core/rpc/netty/MessageCodecHandler.java

+    /**
+     * The constant UTF8.
+     */
+    protected static final Charset UTF8 = Charset.forName("utf-8");


unused
utf8 -> StandardCharsets.UTF_8

slievrly

codec=seata

# Conflicts: # config/seata-config-core/src/main/resources/file.conf # server/src/main/resources/file.conf # test/src/test/resources/file.conf

leizhiyuan · 2019-06-27T03:27:40Z

It seems ok for me in protobuf

slievrly · 2019-06-27T08:30:11Z

slievrly

GlobalBeginRequest

leizhiyuan · 2019-06-27T08:50:45Z

GlobalBeginRequest

I will check it

slievrly · 2019-06-27T08:53:45Z

@leizhiyuan It's my fault. I loaded SW when I started it, causing the class to be delegated.

slievrly

Functional verification has passed.

leizhiyuan and others added 15 commits April 26, 2019 10:35

support protobuf serialization (#871)

e4efab4

Protobuf serialize for merge develop (#911)

628fd52

Merge branch 'develop' into feature_protubuf

fbacba4

Protobuf serialize fix conflict (#918)

bb047b4

Merge branch 'develop' into feature_protubuf

5cc373b

Merge branch 'develop' into feature_protubuf

d4a3889

Merge branch 'develop' into feature_protubuf

162bd53

Merge branch 'develop' into feature_protubuf

ea4facc

Protobuf serialize for cr (#973)

6e069ee

Protobuf serialize for cr (#974)

2842768

Codec for protobuf (#977)

347bc13

Merge branch 'develop' into feature_protubuf

0bd3614

Fix conflict (#982)

591547f

Codec for seata-diy (#1004)

620c74e

fix conflicts

ab5dc51

leizhiyuan changed the title ~~support Feature protobuf~~ support protobuf feature May 10, 2019

leizhiyuan added 2 commits May 10, 2019 10:54

Reform pb serialize. (#1009)

4e6d69b

* reform code * reform protobuf to same module * add new data * use upper case * fix bug,write new pb objetc type * write fullname to data * fix bug add test case

use cache

74c3d25

leizhiyuan requested review from zhangthen and slievrly and removed request for zhangthen May 10, 2019 07:29

leizhiyuan added 2 commits May 13, 2019 19:35

Merge branch 'develop' into feature_probuf

eab440d

# Conflicts: # pom.xml

merge with develop

c8d677d

leizhiyuan force-pushed the feature_probuf branch from 7363603 to c8d677d Compare May 13, 2019 11:51

leizhiyuan requested a review from ujjboy May 13, 2019 12:05

zhangthen added this to the 0.7.0 milestone May 16, 2019

leizhiyuan added 2 commits June 13, 2019 12:26

resolve conflict

4f9cc14

leizhiyuan added 4 commits June 13, 2019 14:39

Merge branch 'develop' into feature_probuf

18e5f37

cherry pick from 3428623

21cc068

fix test case

9c1444c

fix bug

a73bb66

slievrly force-pushed the develop branch from 6c4a95d to fcb273e Compare June 20, 2019 12:34

ujjboy force-pushed the develop branch from fcb273e to 0807ca5 Compare June 20, 2019 12:39

zhangthen approved these changes Jun 25, 2019

View reviewed changes

slievrly reviewed Jun 25, 2019

View reviewed changes

leizhiyuan added 8 commits June 26, 2019 07:30

Merge branch 'develop' into feature_probuf

56a51fe

# Conflicts: # config/seata-config-core/src/main/resources/file.conf # server/src/main/resources/file.conf # test/src/test/resources/file.conf

fix cr

d50f427

Merge branch 'develop' into feature_probuf

67e9fc7

fix dep

7cb2235

Merge branch 'develop' into feature_probuf

a0c14c4

fix for heartbeat

31d2403

fix for null

c2b84e7

fix for null

ea931e5

slievrly reviewed Jun 27, 2019

View reviewed changes

fix npe

9b7a715

slievrly approved these changes Jun 27, 2019

View reviewed changes

slievrly merged commit f49bb8d into develop Jun 27, 2019

ujjboy deleted the feature_probuf branch June 27, 2019 11:48

fescar-robot mentioned this pull request Jun 28, 2019

[WeeklyReport] Weekly report for Seata 2019-6-21 to 2019-6-28 #1252

Closed

nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019

support protobuf feature (apache#1007)

330f710

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support protobuf feature #1007

support protobuf feature #1007

leizhiyuan commented May 9, 2019

codecov-io commented May 9, 2019 •

edited

slievrly commented Jun 17, 2019

zhangthen left a comment

slievrly Jun 25, 2019

slievrly Jun 25, 2019

slievrly left a comment

leizhiyuan commented Jun 27, 2019

slievrly commented Jun 27, 2019

slievrly left a comment

leizhiyuan commented Jun 27, 2019

slievrly commented Jun 27, 2019

slievrly left a comment

support protobuf feature #1007

support protobuf feature #1007

Conversation

leizhiyuan commented May 9, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov-io commented May 9, 2019 • edited

Codecov Report

slievrly commented Jun 17, 2019

zhangthen left a comment

Choose a reason for hiding this comment

slievrly Jun 25, 2019

Choose a reason for hiding this comment

slievrly Jun 25, 2019

Choose a reason for hiding this comment

slievrly left a comment

Choose a reason for hiding this comment

leizhiyuan commented Jun 27, 2019

slievrly commented Jun 27, 2019

slievrly left a comment

Choose a reason for hiding this comment

leizhiyuan commented Jun 27, 2019

slievrly commented Jun 27, 2019

slievrly left a comment

Choose a reason for hiding this comment

codecov-io commented May 9, 2019 •

edited