-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize mysql undo executor #1017
optimize mysql undo executor #1017
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1017 +/- ##
=============================================
- Coverage 39.05% 39.01% -0.05%
- Complexity 1111 1112 +1
=============================================
Files 221 221
Lines 8836 8817 -19
Branches 1132 1125 -7
=============================================
- Hits 3451 3440 -11
+ Misses 4948 4940 -8
Partials 437 437
Continue to review full report at Codecov.
|
rm-datasource/src/main/java/io/seata/rm/datasource/undo/mysql/MySQLUndoInsertExecutor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks.i left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your review, I have fixed it and enhanced the ut. |
The field name in the second row of data actually has no effect on this UT.it should be a mistake. |
rm-datasource/src/main/java/io/seata/rm/datasource/undo/mysql/MySQLUndoUpdateExecutor.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
由于前期Seata社区治理规范问题部分代码作者未签署CLA,可能引发社区知识产权风险问题。请所有在Seata社区贡献过代码(包含:主项目、官网、samples和多语言项目等)的 contributor 帮忙在这个链接登录github账号签署相应的开发者CLA,https://cla-assistant.io/seata/seata 。2023.1.31 未签署CLA的代码将会被rewrite,拜托大家帮忙签一下。 |
Optimize undo sql builder and easier to read.