Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize mysql undo executor #1017

Merged
merged 8 commits into from
May 17, 2019

Conversation

xuzhiyiYoh
Copy link
Contributor

Optimize undo sql builder and easier to read.

@codecov-io
Copy link

codecov-io commented May 12, 2019

Codecov Report

Merging #1017 into develop will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1017      +/-   ##
=============================================
- Coverage      39.05%   39.01%   -0.05%     
- Complexity      1111     1112       +1     
=============================================
  Files            221      221              
  Lines           8836     8817      -19     
  Branches        1132     1125       -7     
=============================================
- Hits            3451     3440      -11     
+ Misses          4948     4940       -8     
  Partials         437      437
Impacted Files Coverage Δ Complexity Δ
...source/undo/mysql/keyword/MySQLKeywordChecker.java 96.96% <ø> (ø) 6 <0> (ø) ⬇️
...in/java/io/seata/rm/datasource/sql/struct/Row.java 90.9% <100%> (+40.9%) 10 <3> (+6) ⬆️
...datasource/undo/mysql/MySQLUndoDeleteExecutor.java 88.88% <100%> (+1.38%) 5 <2> (-1) ⬇️
...datasource/undo/mysql/MySQLUndoUpdateExecutor.java 87.5% <100%> (-3.41%) 4 <1> (-2)
...datasource/undo/mysql/MySQLUndoInsertExecutor.java 86.66% <100%> (-3.34%) 4 <0> (-2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17ffd0a...0771158. Read the comment docs.

@xingfudeshi xingfudeshi self-requested a review May 13, 2019 00:59
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.i left some comments.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuzhiyiYoh
Copy link
Contributor Author

Thanks for your review, I have fixed it and enhanced the ut.
By the way, why there are two different field rows added into before image(see the ut method testDeleteKeywordCheck).
@xingfudeshi

image

@xingfudeshi
Copy link
Member

Thanks for your review, I have fixed it and enhanced the ut.
By the way, why there are two different field rows added into before image(see the ut method testDeleteKeywordCheck).
@xingfudeshi

image

The field name in the second row of data actually has no effect on this UT.it should be a mistake.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit b7e6a59 into apache:develop May 17, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
@wangliang181230 wangliang181230 added this to the 0.5.* milestone Aug 9, 2021
@funky-eyes
Copy link
Contributor

由于前期Seata社区治理规范问题部分代码作者未签署CLA,可能引发社区知识产权风险问题。请所有在Seata社区贡献过代码(包含:主项目、官网、samples和多语言项目等)的 contributor 帮忙在这个链接登录github账号签署相应的开发者CLA,https://cla-assistant.io/seata/seata 。2023.1.31 未签署CLA的代码将会被rewrite,拜托大家帮忙签一下。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants