Provide an all-in-one package for easier usage #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1023 +/- ##
=============================================
- Coverage 38.27% 38.25% -0.03%
Complexity 1046 1046
=============================================
Files 218 218
Lines 8693 8698 +5
Branches 1083 1085 +2
=============================================
Hits 3327 3327
- Misses 4946 4950 +4
- Partials 420 421 +1
Continue to review full report at Codecov.
|
xingfudeshi
reviewed
May 13, 2019
| @@ -0,0 +1,336 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
lovepoem
reviewed
May 13, 2019
| @@ -0,0 +1,612 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
lovepoem
reviewed
May 13, 2019
| @@ -0,0 +1,336 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
lovepoem
reviewed
May 13, 2019
pom.xml
Outdated
| <dependency> | ||
| <groupId>org.junit.platform</groupId> | ||
| <artifactId>junit-platform-launcher</artifactId> | ||
| <version>1.4.2</version> |
There was a problem hiding this comment.
Please extract the version number
|
@xingfudeshi @lovepoem done. |
lovepoem
approved these changes
May 13, 2019
|
lgtm |
ujjboy
approved these changes
May 13, 2019
|
@zhangthen @ujjboy how to ensure the version consistency of the dependencies in bom.xml and all/pom.xml? |
1 task
|
We can then discuss here #1031 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Merge all the following jar‘s code into
seata-alljar, so that users can get all seata's code by dependent onseata-allonly.seata-bomjarMove all the third-party jars to
seata-bomto facilitate the management of third-party jars.Ⅱ. Does this pull request fix one issue?
#914
I had tested the
seata-allin seata-samples, which will release after this PR release.