Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: move the cosul service resource file to correct dir #1024

Merged
merged 3 commits into from
May 13, 2019
Merged

Bugfix: move the cosul service resource file to correct dir #1024

merged 3 commits into from
May 13, 2019

Conversation

zhangthen
Copy link
Contributor

@zhangthen zhangthen commented May 13, 2019 •
edited by xingfudeshi

Move the consul service resource file to correct dir

"io.seata.config.ConfigurationProvider" shoud be in 'META-INF/service' dir

@codecov-io
Copy link

codecov-io commented May 13, 2019 •
edited

Codecov Report

Merging #1024 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1024   +/-   ##
==========================================
  Coverage      38.27%   38.27%           
  Complexity      1046     1046           
==========================================
  Files            218      218           
  Lines           8693     8693           
  Branches        1083     1083           
==========================================
  Hits            3327     3327           
  Misses          4946     4946           
  Partials         420      420

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f84bfb...6383dec. Read the comment docs.

xingfudeshi
xingfudeshi approved these changes May 13, 2019
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi changed the title Bugfix: move the cosule service resource file to correct dir Bugfix: move the cosul service resource file to correct dir May 13, 2019
slievrly
slievrly approved these changes May 13, 2019
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit d4c90e9 into apache:develop May 13, 2019
@fescar-robot fescar-robot mentioned this pull request May 17, 2019
Closed
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
@zhangthen @nick-tan
move the cosule serviec resource to correct dir (apache#1024)
e513a3e
@wangliang181230 wangliang181230 added this to the 0.5.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slievrly slievrly slievrly approved these changes

@xingfudeshi xingfudeshi xingfudeshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.*
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zhangthen @codecov-io @slievrly @xingfudeshi @wangliang181230