Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: release seata configuration #1027

Merged
merged 4 commits into from
May 14, 2019

Conversation

xuzhiyiYoh
Copy link
Contributor

@xuzhiyiYoh xuzhiyiYoh commented May 13, 2019

Ⅰ. Describe what this PR did

Fix release seata configuration.

Ⅱ. Does this pull request fix one issue?

#1020

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

mvn clean install -Dmaven.test.skip=true

profile: release-seata

tree distribution/target/seata-server-0.6.0-SNAPSHOT/seata

image

Ⅴ. Special notes for reviews

What does the following configuration mean?

        <file>
            <source>../server/target/seata-server-${project.version}.jar</source>
            <outputDirectory>/target/</outputDirectory>
        </file>

@xuzhiyiYoh xuzhiyiYoh changed the title fix release seate Bugfix: release seata configuration May 13, 2019
@codecov-io
Copy link

codecov-io commented May 13, 2019

Codecov Report

Merging #1027 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1027   +/-   ##
==========================================
  Coverage      38.23%   38.23%           
  Complexity      1046     1046           
==========================================
  Files            218      218           
  Lines           8701     8701           
  Branches        1086     1086           
==========================================
  Hits            3327     3327           
  Misses          4953     4953           
  Partials         421      421

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dbf920...a4ada24. Read the comment docs.

<destName>NOTICE</destName>
</file>
<file>
<source>../server/target/seata-server-${project.version}.jar</source>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when mvn install,it will create a xxx.tar.gz?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My test result.

image

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuzhiyiYoh
Copy link
Contributor Author

mvn clean install -Dmaven.test.skip=true -Prelease-seata

@xingfudeshi xingfudeshi self-requested a review May 14, 2019 02:39
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.LGTM.

@lovepoem lovepoem merged commit cc951af into apache:develop May 14, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
@wangliang181230 wangliang181230 added this to the 0.5.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants