Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable createDependencyReducedPom #1033

Merged

Conversation

lovepoem
Copy link
Member

Ⅰ. Describe what this PR did

disable createDependencyReducedPom to avoid the disable createDependencyReducedPom

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

ci pass

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented May 14, 2019

Codecov Report

Merging #1033 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1033   +/-   ##
==========================================
  Coverage      38.23%   38.23%           
  Complexity      1046     1046           
==========================================
  Files            218      218           
  Lines           8701     8701           
  Branches        1086     1086           
==========================================
  Hits            3327     3327           
  Misses          4953     4953           
  Partials         421      421

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13f832...f8e5dc1. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if not maven-shade-plugin will create dependency-reduced-pom.xml

@xingfudeshi xingfudeshi self-requested a review May 14, 2019 09:38
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit 45b99b7 into apache:develop May 14, 2019
@lovepoem lovepoem deleted the disable_createDependencyReducedPom branch May 14, 2019 11:38
zhangthen added a commit to zhangthen/seata that referenced this pull request May 22, 2019
zhangthen added a commit to zhangthen/seata that referenced this pull request May 23, 2019
zhangthen added a commit to zhangthen/seata that referenced this pull request May 23, 2019
leizhiyuan pushed a commit that referenced this pull request May 23, 2019
* undo  pr #1033

* undo  pr #1033

* modify file.conf

* Update .gitignore

* Update .gitignore
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
* undo  pr apache#1033

* undo  pr apache#1033

* modify file.conf

* Update .gitignore

* Update .gitignore
@wangliang181230 wangliang181230 added this to the 0.5.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants