replace Chinese comments #1036
Merged
replace Chinese comments #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1036 +/- ##
=========================================
Coverage 38.5% 38.5%
Complexity 1076 1076
=========================================
Files 220 220
Lines 8774 8774
Branches 1108 1108
=========================================
Hits 3378 3378
Misses 4966 4966
Partials 430 430
Continue to review full report at Codecov.
|
slievrly
reviewed
May 15, 2019
common/src/main/java/io/seata/common/exception/FrameworkErrorCode.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
May 15, 2019
| /** | ||
| * The Net disconnect. | ||
| */ | ||
| NetDisconnect("0103", "seataConnection closed", "网络断开，请检查到对端（client 或seata server）的网络连接"), | ||
| NetDisconnect("0103", "Seata Connection closed", "The network is disconnected. Please check the network connection to the client or seata server."), |
xingfudeshi
requested changes
May 16, 2019
| /** | ||
| * The Net disconnect. | ||
| */ | ||
| NetDisconnect("0103", "seataConnection closed", "网络断开，请检查到对端（client 或seata server）的网络连接"), | ||
| NetDisconnect("0103", "Seata Connection closed", "The network is disconnected. Please check the network connection to the client or seata server."), |
…xuzhiyiYoh/seata into enhance/remove_chinese_comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Replace some Chinese comments.
Ⅱ. Does this pull request fix one issue?
#732
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews