refactor: exceptionHandleTemplate #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix global status is null
Codecov Report
@@ Coverage Diff @@
## develop #1040 +/- ##
============================================
- Coverage 38.6% 38.51% -0.1%
Complexity 1067 1067
============================================
Files 218 218
Lines 8701 8722 +21
Branches 1086 1088 +2
============================================
Hits 3359 3359
- Misses 4920 4941 +21
Partials 422 422
Continue to review full report at Codecov.
|
slievrly
reviewed
May 15, 2019
server/src/main/java/io/seata/server/AbstractTCInboundHandler.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/exception/AbstractExceptionHandler.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/seata/server/AbstractTCInboundHandler.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/seata/server/AbstractTCInboundHandler.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/seata/server/AbstractTCInboundHandler.java
Outdated
Show resolved
Hide resolved
slievrly
changed the title
slievrly
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix global status is null
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #922
notice！ here, when occurs exception, what the correct global status should we return? please review it. I can change it later.
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews