Add sofa-rpc integration for context propagation. #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1043 +/- ##
============================================
- Coverage 38.51% 38.5% -0.02%
- Complexity 1067 1076 +9
============================================
Files 218 220 +2
Lines 8722 8774 +52
Branches 1088 1108 +20
============================================
+ Hits 3359 3378 +19
- Misses 4941 4966 +25
- Partials 422 430 +8
Continue to review full report at Codecov.
|
zhangthen
reviewed
May 15, 2019
slievrly
reviewed
May 15, 2019
| * TransactionContext on provider side. | ||
| */ | ||
| @Extension(value = "transactionContextProvider") | ||
| @AutoActive(providerSide = true) |
There was a problem hiding this comment.
Why are consumerSide and providerSide not combined?
@AutoActive(providerSide = true，consumerSide = true)
There was a problem hiding this comment.
There are some different logic.
|
@zhangthen @slievrly done. |
zhangthen
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Fix #1042