Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break undo if data snapshot is not changed. #1051

Merged
merged 3 commits into from
May 16, 2019

Conversation

ujjboy
Copy link
Contributor

@ujjboy ujjboy commented May 15, 2019

Ⅰ. Describe what this PR did

  • Add DataCompareUtils
  • Add some test case.
  • Do not execute undo if the before data snapshot is equivalent to the after data snapshot.

Ⅱ. Does this pull request fix one issue?

Part of #1049

@codecov-io
Copy link

codecov-io commented May 15, 2019

Codecov Report

Merging #1051 into develop will increase coverage by 0.35%.
The diff coverage is 84.84%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1051      +/-   ##
=============================================
+ Coverage      38.49%   38.85%   +0.35%     
- Complexity      1077     1111      +34     
=============================================
  Files            220      221       +1     
  Lines           8772     8836      +64     
  Branches        1108     1132      +24     
=============================================
+ Hits            3377     3433      +56     
- Misses          4965     4966       +1     
- Partials         430      437       +7
Impacted Files Coverage Δ Complexity Δ
...ain/java/io/seata/common/util/CollectionUtils.java 62.5% <100%> (+62.5%) 5 <5> (+5) ⬆️
...seata/rm/datasource/undo/AbstractUndoExecutor.java 82.85% <25%> (-5.03%) 8 <4> (ø)
...rc/main/java/io/seata/common/util/StringUtils.java 12.5% <66.66%> (+4.92%) 10 <4> (+4) ⬆️
.../java/io/seata/rm/datasource/DataCompareUtils.java 90.19% <90.19%> (ø) 24 <24> (?)
...o/seata/rm/datasource/sql/struct/TableRecords.java 38.59% <0%> (+1.75%) 9% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c5a3ab...26c8563. Read the comment docs.

Copy link
Contributor

@zhangthen zhangthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhangthen zhangthen merged commit 4fc5977 into apache:develop May 16, 2019
@ujjboy ujjboy deleted the undo_ingnore branch May 16, 2019 08:22
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
@wangliang181230 wangliang181230 added this to the 0.5.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants