-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break undo if data snapshot is not changed. #1051
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1051 +/- ##
=============================================
+ Coverage 38.49% 38.85% +0.35%
- Complexity 1077 1111 +34
=============================================
Files 220 221 +1
Lines 8772 8836 +64
Branches 1108 1132 +24
=============================================
+ Hits 3377 3433 +56
- Misses 4965 4966 +1
- Partials 430 437 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ⅰ. Describe what this PR did
undo
if the before data snapshot is equivalent to the after data snapshot.Ⅱ. Does this pull request fix one issue?
Part of #1049