Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1061 size wrong between xid and branchId #1064

Merged
merged 4 commits into from
May 19, 2019

Conversation

github-ygy
Copy link
Contributor

Ⅰ. Describe what this PR did

size wrong between xid and branchId which will delete fail

Ⅱ. Does this pull request fix one issue?

fix #1061

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented May 17, 2019

Codecov Report

Merging #1064 into develop will decrease coverage by <.01%.
The diff coverage is 60%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1064      +/-   ##
=============================================
- Coverage      39.08%   39.07%   -0.01%     
  Complexity      1119     1119              
=============================================
  Files            221      221              
  Lines           8833     8832       -1     
  Branches        1130     1130              
=============================================
- Hits            3452     3451       -1     
  Misses          4940     4940              
  Partials         441      441
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/seata/rm/datasource/AsyncWorker.java 16.43% <0%> (ø) 4 <0> (ø) ⬇️
...va/io/seata/rm/datasource/undo/UndoLogManager.java 23.22% <100%> (-0.5%) 8 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 111b6f8...c1b221e. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lixuzhou lixuzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also fixed issue #1065

@xingfudeshi xingfudeshi merged commit 95eab9c into apache:develop May 19, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
@wangliang181230 wangliang181230 added this to the 0.6.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

batch delete bug in sqlbuilder
6 participants