-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #1061 size wrong between xid and branchId #1064
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1064 +/- ##
=============================================
- Coverage 39.08% 39.07% -0.01%
Complexity 1119 1119
=============================================
Files 221 221
Lines 8833 8832 -1
Branches 1130 1130
=============================================
- Hits 3452 3451 -1
Misses 4940 4940
Partials 441 441
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this also fixed issue #1065
Ⅰ. Describe what this PR did
size wrong between xid and branchId which will delete fail
Ⅱ. Does this pull request fix one issue?
fix #1061
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews