Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache configuration instance. #1082

Merged
merged 3 commits into from
May 22, 2019
Merged

Cache configuration instance. #1082

merged 3 commits into from
May 22, 2019

Conversation

ujjboy
Copy link
Contributor

@ujjboy ujjboy commented May 21, 2019

Ⅰ. Describe what this PR did

  • Cache singleton configuration instance.

Ⅱ. Does this pull request fix one issue?

Fix #1077

@codecov-io
Copy link

codecov-io commented May 21, 2019 •
edited

Codecov Report

Merging #1082 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1082   +/-   ##
==========================================
  Coverage      39.94%   39.94%           
  Complexity      1153     1153           
==========================================
  Files            222      222           
  Lines           8929     8929           
  Branches        1158     1158           
==========================================
  Hits            3567     3567           
  Misses          4914     4914           
  Partials         448      448

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f522e7a...85ec3d6. Read the comment docs.

slievrly
slievrly approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xingfudeshi
xingfudeshi reviewed May 21, 2019
View reviewed changes
discovery/seata-discovery-core/src/test/java/io/seata/config/ConfigurationFactoryTest.java Outdated
import org.junit.jupiter.api.Test;

/**
* @author <a href="mailto:zhanggeng.zg@antfin.com">GengZhang</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove a tag

@ujjboy
Copy link
Contributor Author

ujjboy commented May 22, 2019

@xingfudeshi done.

xingfudeshi
xingfudeshi approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit 18e247b into apache:develop May 22, 2019
@ujjboy ujjboy deleted the cache_config branch May 22, 2019 06:46
@fescar-robot fescar-robot mentioned this pull request May 24, 2019
Closed
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
@ujjboy @nick-tan
Cache configuration instance. (apache#1082)
742ea05
@wangliang181230 wangliang181230 added this to the 0.6.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slievrly slievrly slievrly approved these changes

@xingfudeshi xingfudeshi xingfudeshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.*
Development

Successfully merging this pull request may close these issues.

ConfigurationFactory getInstance has no cache.
5 participants
@ujjboy @codecov-io @slievrly @xingfudeshi @wangliang181230