Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Charset using and blob utils. #1084

Merged
merged 3 commits into from
May 22, 2019
Merged

Conversation

ujjboy
Copy link
Contributor

@ujjboy ujjboy commented May 21, 2019

Ⅰ. Describe what this PR did

  • All use default UTF-8 charset
  • Remove BlobUtils#inputStream2String() which duplicate with StringUtils
  • Delete StringUtils#string2blob() which duplicate with BlobUtils
  • Add BlobUtils#blob2Bytes() and BlobUtils#bytes2Blob()
  • Add more test case.

@codecov-io
Copy link

codecov-io commented May 21, 2019

Codecov Report

Merging #1084 into develop will increase coverage by 0.18%.
The diff coverage is 77.41%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1084      +/-   ##
=============================================
+ Coverage      39.94%   40.13%   +0.18%     
- Complexity      1153     1163      +10     
=============================================
  Files            222      222              
  Lines           8929     8940      +11     
  Branches        1158     1158              
=============================================
+ Hits            3567     3588      +21     
+ Misses          4914     4907       -7     
+ Partials         448      445       -3
Impacted Files Coverage Δ Complexity Δ
...va/io/seata/rm/datasource/undo/UndoLogManager.java 23.22% <0%> (ø) 8 <0> (ø) ⬇️
...n/java/io/seata/core/protocol/AbstractMessage.java 15.51% <100%> (ø) 5 <1> (ø) ⬇️
...ommon/src/main/java/io/seata/common/Constants.java 50% <100%> (+50%) 1 <1> (+1) ⬆️
.../io/seata/common/loader/EnhancedServiceLoader.java 68.86% <100%> (ø) 23 <0> (ø) ⬇️
...rc/main/java/io/seata/common/util/StringUtils.java 24.05% <76.47%> (+11.55%) 13 <6> (+3) ⬆️
.../src/main/java/io/seata/common/util/BlobUtils.java 60% <80%> (+48.23%) 8 <4> (+6) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18e247b...e1d8eed. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangthen zhangthen merged commit 42d4162 into apache:develop May 22, 2019
@ujjboy ujjboy deleted the code_refactor branch May 22, 2019 06:46
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
@wangliang181230 wangliang181230 added this to the 0.6.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants