-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the method definition of UndoLogParser for better extensibility. #1090
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1090 +/- ##
=============================================
- Coverage 41.87% 41.73% -0.14%
Complexity 1361 1361
=============================================
Files 243 243
Lines 10112 10118 +6
Branches 1321 1325 +4
=============================================
- Hits 4234 4223 -11
- Misses 5329 5347 +18
+ Partials 549 548 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just modify the return type of "UndoLogParser", LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the title ,It fixes a bug of JSON encode
@github-ygy need your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ⅰ. Describe what this PR did
transient
instead of@JSONField(serialize = false)
for ignore serialization of fieldtableMeta
Ⅱ. Does this pull request fix one issue?
Fix #1088