UndoLogParser change to SPI. #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1099 +/- ##
=============================================
- Coverage 41.84% 41.83% -0.01%
Complexity 1361 1361
=============================================
Files 243 243
Lines 10111 10113 +2
Branches 1319 1319
=============================================
Hits 4231 4231
- Misses 5334 5335 +1
- Partials 546 547 +1
Continue to review full report at Codecov.
|
xingfudeshi
reviewed
May 24, 2019
| */ | ||
| public class UndoLogParserFactory { | ||
|
|
||
| private static class SingletonHolder { | ||
| private static final UndoLogParser INSTANCE = new JSONBasedUndoLogParser(); | ||
| private static UndoLogParser INSTANCE; |
There was a problem hiding this comment.
maybe there should use final?
There was a problem hiding this comment.
Ok, I' will modify it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
UndoLogParserchange to SPI mode and makefastjsonas default implement.transaction.undo.log.serializationⅡ. Does this pull request fix one issue?
Fix #1010