Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix field type is datetime equals fail #1117

Merged
merged 1 commit into from
May 28, 2019
Merged

fix field type is datetime equals fail #1117

merged 1 commit into from
May 28, 2019

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented May 28, 2019

fix: #1116

@codecov-io
Copy link

codecov-io commented May 28, 2019

Codecov Report

Merging #1117 into develop will decrease coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1117      +/-   ##
=============================================
- Coverage      41.87%   41.87%   -0.01%     
  Complexity      1361     1361              
=============================================
  Files            243      243              
  Lines          10106    10112       +6     
  Branches        1319     1321       +2     
=============================================
+ Hits            4232     4234       +2     
- Misses          5327     5329       +2     
- Partials         547      549       +2
Impacted Files Coverage Δ Complexity Δ
.../java/io/seata/rm/datasource/DataCompareUtils.java 84.21% <33.33%> (-5.99%) 24 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 582d069...c78c34c. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly
Copy link
Member

@jsbxyyx modify your pr title,will be as commit log.

@ujjboy
Copy link
Contributor

ujjboy commented May 28, 2019

I think this is not a real solution, the reason for #1116 is the json serialization loses millisecond precision.

@jsbxyyx jsbxyyx changed the title Update DataCompareUtils.java fix field type is datetime equals fail May 28, 2019
@jsbxyyx
Copy link
Member Author

jsbxyyx commented May 28, 2019

@ujjboy

the problem is not json serialization loses millisecond precision, you look the value type afterRecords is String, currentRecords is Timestamp

I also think this is not a good solution. the problem solution requires a serialization method that retain the type.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhangthen
Copy link
Contributor

zhangthen commented May 28, 2019

The actual reason is that the serialization protocol(fastjson) used by undo log is not a good one.

We can fix it with this temporary solution first.

@zhangthen zhangthen merged commit 0aeff8d into apache:develop May 28, 2019
@jsbxyyx jsbxyyx deleted the patch-1 branch May 28, 2019 06:45
@jsbxyyx jsbxyyx restored the patch-1 branch May 28, 2019 07:28
@jsbxyyx jsbxyyx deleted the patch-1 branch May 28, 2019 07:29
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
@wangliang181230 wangliang181230 added this to the 0.6.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mysql field type is datetime afterRecords not equals currentRecords
7 participants