-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix field type is datetime equals fail #1117
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1117 +/- ##
=============================================
- Coverage 41.87% 41.87% -0.01%
Complexity 1361 1361
=============================================
Files 243 243
Lines 10106 10112 +6
Branches 1319 1321 +2
=============================================
+ Hits 4232 4234 +2
- Misses 5327 5329 +2
- Partials 547 549 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jsbxyyx modify your pr title,will be as commit log. |
I think this is not a real solution, the reason for #1116 is the |
the problem is not json serialization loses millisecond precision, you look the value type afterRecords is String, currentRecords is Timestamp I also think this is not a good solution. the problem solution requires a serialization method that retain the type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The actual reason is that the serialization protocol(fastjson) used by undo log is not a good one. We can fix it with this temporary solution first. |
fix: #1116