Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support weibo/motan #1119

Merged
merged 2 commits into from
May 29, 2019
Merged

support weibo/motan #1119

merged 2 commits into from
May 29, 2019

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

support weibo/motan

Ⅱ. Does this pull request fix one issue?

fix #1086

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented May 28, 2019

Codecov Report

Merging #1119 into develop will increase coverage by 0.03%.
The diff coverage is 62.5%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1119      +/-   ##
=============================================
+ Coverage      41.81%   41.84%   +0.03%     
- Complexity      1361     1366       +5     
=============================================
  Files            243      244       +1     
  Lines          10141    10165      +24     
  Branches        1325     1333       +8     
=============================================
+ Hits            4240     4254      +14     
- Misses          5351     5356       +5     
- Partials         550      555       +5
Impacted Files Coverage Δ Complexity Δ
...eata/integration/motan/MotanTransactionFilter.java 62.5% <62.5%> (ø) 5 <5> (?)
...server/store/file/FileTransactionStoreManager.java 45.29% <0%> (-0.35%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b5a741...455aa7d. Read the comment docs.

Copy link
Contributor

@zhangthen zhangthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slievrly slievrly merged commit 052b432 into apache:develop May 29, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
Signed-off-by: slievrly <slievrly@163.com>
@wangliang181230 wangliang181230 added this to the 0.6.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seata does not support Motan
5 participants