Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix : use xid wrong when do branch commit and rollback #1120

Merged
merged 2 commits into from
May 29, 2019

Conversation

zhangthen
Copy link
Contributor

fix #1118

Use the xid wrong when do branch commit and rollback.

@codecov-io
Copy link

codecov-io commented May 28, 2019

Codecov Report

Merging #1120 into develop will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1120      +/-   ##
=============================================
- Coverage      41.83%   41.82%   -0.01%     
  Complexity      1361     1361              
=============================================
  Files            243      243              
  Lines          10141    10141              
  Branches        1325     1325              
=============================================
- Hits            4242     4241       -1     
  Misses          5351     5351              
- Partials         548      549       +1
Impacted Files Coverage Δ Complexity Δ
...o/seata/server/coordinator/DefaultCoordinator.java 33.86% <0%> (ø) 13 <0> (ø) ⬇️
.../java/io/seata/server/coordinator/DefaultCore.java 57.41% <100%> (ø) 24 <0> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 45.99% <0%> (-0.35%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca9ae4e...2341937. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standalone is normal, this problem occurs with stateless clusters?XID.generateXID dependent on localIp

@zhangthen
Copy link
Contributor Author

Standalone is normal, this problem occurs with stateless clusters?XID.generateXID dependent on localIp

It occur when transaction start on one server, and commit on another server.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Branch transcation cannot be committed when there are multiple transaction coordinator instance
5 participants