-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix : use xid wrong when do branch commit and rollback #1120
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1120 +/- ##
=============================================
- Coverage 41.83% 41.82% -0.01%
Complexity 1361 1361
=============================================
Files 243 243
Lines 10141 10141
Branches 1325 1325
=============================================
- Hits 4242 4241 -1
Misses 5351 5351
- Partials 548 549 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Standalone is normal, this problem occurs with stateless clusters?XID.generateXID dependent on localIp
It occur when transaction start on one server, and commit on another server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix #1118
Use the xid wrong when do branch commit and rollback.