bugfix: seata-server.bat classpath too long #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## develop #1138 +/- ##
==========================================
Coverage 41.86% 41.86%
Complexity 1366 1366
==========================================
Files 244 244
Lines 10165 10165
Branches 1333 1333
==========================================
Hits 4256 4256
Misses 5355 5355
Partials 554 554Continue to review full report at Codecov.
|
leizhiyuan
approved these changes
May 30, 2019
xingfudeshi
reviewed
May 30, 2019
xingfudeshi
requested changes
May 30, 2019
Signed-off-by: slievrly <slievrly@163.com>
|
@xingfudeshi has fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
when the server is running in windows, the classpath is too long to failure start.
Ⅱ. Does this pull request fix one issue?
fix #1136
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews