-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change LockMode from MEMORY to DB when the StoreMode is DB #1145
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1145 +/- ##
=============================================
- Coverage 41.9% 41.88% -0.02%
Complexity 1372 1372
=============================================
Files 245 245
Lines 10188 10194 +6
Branches 1332 1334 +2
=============================================
+ Hits 4269 4270 +1
- Misses 5364 5367 +3
- Partials 555 557 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if startup in file mode and use db lock ,can it work?
String lockMode = CONFIG.getConfig(ConfigurationKeys.LOCK_MODE); | ||
//storeMode == db and lockMode == memeory is not allowed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove the settings of lock mode, only one setting: "storeMode"?
Ⅰ. Describe what this PR did
If the StoreMode is 'DB' and the LockMode is 'MEMORY', the locks in 'MEMORY' cann't be released normally after the transaction commit or rollback.
Ⅱ. Does this pull request fix one issue?
Change LockMode from MEMORY to DB automatically when the StoreMode is DB .