bugfix:the buffer may cause overflows when sql statement is long #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1148 +/- ##
=============================================
- Coverage 41.97% 41.96% -0.01%
Complexity 1385 1385
=============================================
Files 246 246
Lines 10240 10239 -1
Branches 1343 1343
=============================================
- Hits 4298 4297 -1
Misses 5378 5378
Partials 564 564
Continue to review full report at Codecov.
|
xingfudeshi
changed the title
leizhiyuan
reviewed
Jun 3, 2019
core/src/main/java/io/seata/core/protocol/MergedWarpMessage.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Jun 4, 2019
core/src/main/java/io/seata/core/protocol/MergedWarpMessage.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Due to the
java.nio.ByteBuffercan not grow dynamically, its size is hardcoded now, this patch replacesjava.nio.ByteBufferwithio.netty.buffer.ByteBuf, which can grow on demand.Ⅱ. Does this pull request fix one issue?
fixes issue #976
Ⅲ. Why don't you add test cases (unit test/integration test)?
There is already tests upon this method.
Ⅳ. Describe how to verify it
CI passes
Ⅴ. Special notes for reviews
null