Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset initialized flag & instance while destroy(). split PR #1105 #1162

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

cherrylzhao
Copy link
Member

Ⅰ. Describe what this PR did

reset initialized flag & instance when destroy RpcClient.

Ⅱ. Does this pull request fix one issue?

fix #983

Ⅲ. Why don't you add test cases (unit test/integration test)?

unit test is included in another PR, for splitting #1105 into 2 PRs.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@cherrylzhao cherrylzhao changed the title reset initialized flag & instance while destroy(). split PR #1105 Reset initialized flag & instance while destroy(). split PR #1105 Jun 4, 2019
@codecov-io
Copy link

codecov-io commented Jun 4, 2019

Codecov Report

Merging #1162 into develop will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1162      +/-   ##
=============================================
- Coverage      41.97%   41.92%   -0.06%     
  Complexity      1385     1385              
=============================================
  Files            246      246              
  Lines          10239    10247       +8     
  Branches        1343     1343              
=============================================
- Hits            4298     4296       -2     
- Misses          5378     5386       +8     
- Partials         563      565       +2
Impacted Files Coverage Δ Complexity Δ
...main/java/io/seata/core/rpc/netty/RmRpcClient.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...main/java/io/seata/core/rpc/netty/TmRpcClient.java 28.48% <0%> (-0.68%) 12 <0> (ø)
...server/store/file/FileTransactionStoreManager.java 45.64% <0%> (-0.7%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3428623...5ad626e. Read the comment docs.

Copy link
Contributor

@leizhiyuan leizhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cherrylzhao
Copy link
Member Author

cherrylzhao commented Jun 4, 2019

thanks for reply, as #1105 PR is too big, I have split it into 2 PRs.
#1105 also include some refactor work except fix the close logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Seata and ShardingSphere
4 participants