-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: use Set to avoid duplicate listeners. fixes #1126 #1169
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1169 +/- ##
============================================
- Coverage 43.42% 43.4% -0.03%
Complexity 1428 1428
============================================
Files 250 250
Lines 10224 10222 -2
Branches 1333 1333
============================================
- Hits 4440 4437 -3
Misses 5202 5202
- Partials 582 583 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comment
Is the hashset's order of addition and traversal order consistent? There is currently no order requirement in the business. |
yes,what I mean is the order of hashset, but the method name is 'getSortedBranches' maybe I think that sort it well.. |
yeah, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
This patch replaces
ArrayList
withHaseSet
to avoid duplicated listeners as described in #1126 , and also fix some typosⅡ. Does this pull request fix one issue?
fixes #1126
Ⅲ. Why don't you add test cases (unit test/integration test)?
Already have
Ⅳ. Describe how to verify it
CI passes
Ⅴ. Special notes for reviews
null