Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused semicolons #1190

Merged
merged 7 commits into from
Jun 15, 2019
Merged

remove unused semicolons #1190

merged 7 commits into from
Jun 15, 2019

Conversation

arnkore
Copy link
Contributor

@arnkore arnkore commented Jun 11, 2019

Ⅰ. Describe what this PR did

remove unused semicolons

Ⅱ. Does this pull request fix one issue?

fixes #540

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jun 11, 2019

Codecov Report

Merging #1190 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1190      +/-   ##
=============================================
+ Coverage      43.51%   43.54%   +0.02%     
  Complexity      1428     1428              
=============================================
  Files            250      250              
  Lines          10208    10208              
  Branches        1330     1330              
=============================================
+ Hits            4442     4445       +3     
+ Misses          5181     5179       -2     
+ Partials         585      584       -1
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/server/session/SessionHolder.java 53.16% <ø> (ø) 15 <0> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 47.03% <0%> (+1.04%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f898c8...aa8f04f. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arnkore please associate with your github email.

Copy link
Contributor

@leizhiyuan leizhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

@leizhiyuan leizhiyuan added this to the 0.7.0 milestone Jun 14, 2019
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit cf30173 into apache:develop Jun 15, 2019
@leizhiyuan leizhiyuan modified the milestone: 0.7.0 Jul 10, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove useless, format and javadoc for core module
6 participants