-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get lockmode by the storemode #1193
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1193 +/- ##
==========================================
Coverage ? 43.41%
Complexity ? 1428
==========================================
Files ? 250
Lines ? 10217
Branches ? 1331
==========================================
Hits ? 4436
Misses ? 5199
Partials ? 582
Continue to review full report at Codecov.
|
server/src/main/resources/file.conf
Outdated
memory{ | ||
## store lock in memory of server | ||
} | ||
mode = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we remove lock.mode from conf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we remove lock.mode from conf
I'll use “lock.mode” in some other cases.
@@ -82,11 +82,7 @@ store { | |||
} | |||
lock { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think should delete the lock node, which is strongly associated with the store. As for the table name, we should use our default table name just like undolog
, and do not need to allow user settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think should delete the lock node, which is strongly associated with the store. As for the table name, we should use our default table name just like
undolog
, and do not need to allow user settings.
I will store the row locks in the user's database, beside the undo_log table, and need a lock node to configure this switcher.
and modify the usage of lock.mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#1192