Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check the third-party dependencies license #1198

Merged
merged 2 commits into from
Jun 13, 2019
Merged

check the third-party dependencies license #1198

merged 2 commits into from
Jun 13, 2019

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

check the third-party dependencies license

Ⅱ. Does this pull request fix one issue?

fix #1197

image

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

slievrly and others added 2 commits June 12, 2019 20:28
@codecov-io
Copy link

codecov-io commented Jun 13, 2019

Codecov Report

Merging #1198 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1198      +/-   ##
=============================================
- Coverage      43.53%   43.51%   -0.02%     
  Complexity      1430     1430              
=============================================
  Files            250      250              
  Lines          10225    10225              
  Branches        1332     1332              
=============================================
- Hits            4451     4449       -2     
- Misses          5189     5190       +1     
- Partials         585      586       +1
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 46.34% <0%> (-0.7%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 442e048...c840275. Read the comment docs.

Copy link
Contributor

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhangthen zhangthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhangthen zhangthen merged commit fae1276 into apache:develop Jun 13, 2019
@leizhiyuan leizhiyuan added this to the 0.7.0 milestone Jul 10, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check third-party dependencies license
5 participants