Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output branchRollback failed log #1202

Merged
merged 2 commits into from
Jun 15, 2019
Merged

output branchRollback failed log #1202

merged 2 commits into from
Jun 15, 2019

Conversation

zjinlei
Copy link
Contributor

@zjinlei zjinlei commented Jun 14, 2019

Ⅰ. Describe what this PR did

输出底层上抛的回滚失败日志

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jun 14, 2019

Codecov Report

Merging #1202 into develop will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1202      +/-   ##
=============================================
- Coverage      43.52%   43.49%   -0.03%     
  Complexity      1428     1428              
=============================================
  Files            250      250              
  Lines          10220    10222       +2     
  Branches        1330     1331       +1     
=============================================
- Hits            4448     4446       -2     
- Misses          5187     5191       +4     
  Partials         585      585
Impacted Files Coverage Δ Complexity Δ
...java/io/seata/rm/datasource/DataSourceManager.java 27.41% <0%> (-0.92%) 7 <0> (ø)
...server/store/file/FileTransactionStoreManager.java 46.34% <0%> (-0.7%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7437852...bfe2cf2. Read the comment docs.

@xingfudeshi xingfudeshi self-requested a review June 14, 2019 04:36
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.LGTM.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 7584fc7 into apache:develop Jun 15, 2019
@zjinlei zjinlei deleted the develop branch June 24, 2019 08:52
@leizhiyuan leizhiyuan added this to the 0.7.0 milestone Jul 10, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants